Remove dead code, unused deps, and stale docs#42
Merged
DorianZheng merged 3 commits intomainfrom Mar 23, 2026
Merged
Conversation
- Delete unimplemented deployment schema, DB tables, and design doc - Remove unused uuid and @types/uuid dependencies (code uses node:crypto) - Remove unused iconFiles export and Files import from icons.ts - Fix README references to nonexistent make targets (run, electron-dev, electron-pack)
The lucide icon library was imported but never listed in package.json, causing build and dev server failures.
At <=980px, the sidebar column collapses to 0 width instead of switching to a top-row layout that crowded the content area. The toggle button remains available at all viewport sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/shared/src/schemas/deployment.ts), 3 DB tables + indexes indatabase.ts, and design doc (docs/deployment-function-ui-design.md)uuidand@types/uuiddependencies from backend (code usesnode:cryptorandomUUID())iconFilesexport andFilesimport from frontend iconsmake run,make electron-dev,make electron-packtargets; remove link to deleted deployment docTest plan
pnpm --filter @dune/shared buildpassespnpm --filter @dune/backend buildpassesmake test— all failures are pre-existing on main (verified by running on clean main)