Initial version of miniwallet server #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

johnwhitton wants to merge 8 commits into main from miniserver

Collaborator

johnwhitton commented Aug 22, 2022 •

edited

Loading

This PR will include chain-code enhancements #3 and miniserver functionality #5


          Initial version of miniwallet server

c0473e2

johnwhitton mentioned this pull request

MiniServer: basic mini-wallet operator functionality #5

Open

17 tasks

johnwhitton added 2 commits

August 22, 2022 14:33


          Add in sms message parsing and responses in twilio format

ac251c4


          Fix logic error in funding where funder and recipient were backwards

e45388c

polymorpher reviewed

View reviewed changes

miniserver/app.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/blockchain.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/blockchain.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/config.js

+              const ethers = require('ethers')
+              const DEBUG = process.env.MINISERVER_DEBUG === 'true' || process.env.MINISERVER_DEBUG === '1'
+              const APIDOCS = process.env.APIDOCS === 'true' || process.env.APIDOCS === '1'
+              const config = {

Owner

polymorpher Aug 25, 2022

Let's clean this up to bare minimum

Collaborator Author

johnwhitton Aug 30, 2022

Have updated @polymorpher can you review again and see what else (if anything) should be removed 🙏

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/src/data/datastore.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/routes/index.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/src/data/generic.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/utils.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/src/data/user.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/src/data/setting.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

miniserver/src/data/request.js Outdated Show resolved Hide resolved

polymorpher reviewed

View reviewed changes

server/config.js Outdated Show resolved Hide resolved

polymorpher requested changes

View reviewed changes

Owner

polymorpher left a comment

Looks on the right track - we need to handle errors better, make code more consistent with common styles and good practice, and reduce code duplications

polymorpher mentioned this pull request

Enhance server capabilities for miniwallet and sms callbacks #6

Closed

29 tasks

johnwhitton added 5 commits

August 27, 2022 12:50


          WIP: Begin work on Miniserver multiple operators per node and other f…

a234cf9

…eedback from PR 7


          WIP add executor logic to blockchain.js to support multiple accounts …

70ee740

…using mnemonic


          Working version of executor supporting multiple accounts via mnemonic

4b988b4


          Remove miniserver src/data files and use servers for now (consider mo…

a47c25b

…ving to shared)


          Improve error handling for miniserver

86c7933

This was referenced Aug 30, 2022

Miniwallet enhancements (including miniserver and smart contract changes) #8

Closed

MiniWallet - Launch Task List #13

Open

Collaborator Author

johnwhitton commented Sep 1, 2022

Closing this as being progressed under #8
After 8 is merged will review any outstanding items here and add them to #13

johnwhitton closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet