-
Notifications
You must be signed in to change notification settings - Fork 88
Extend GIS Support to the Document and Graph Model #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
murermader
wants to merge
323
commits into
master
Choose a base branch
from
multimodel-gis2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgeo to adapter testing suit
datomo
approved these changes
Nov 8, 2025
Member
datomo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some adjustments this now looks good to me. Thx @murermader!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for spatial functions from MongoDB and Neo4j to the document and graph model respectively. This PR extends the backend, while Polypheny-UI: Add the Map-Based Query Mode for Working with Spatial Data #103 extends the frontend.
Changes
withinGeometry,point.distance(a, b, 'neo4j')(function overload, to use the same distance approximation as Neo4j uses, with a different earth radius)docker, to exclude docker tests for different platform testsplatformTeststo have better control on what can be tested via Github actions on different platforms.Fixes
Sortalgebra node and its enumeration for some relational and all document casesTests
Changes are tested with unit test. Functionality is validated for all added functions. If possible, behavior is also compared with the reference implementation through Docker (Neo4j, MongoDB).
Added files:
CypherGeoFunctionsTest.javaMqlGeoFunctionsTest.java