Skip to content

Remove final solc invocation from solc_download.sh#2

Open
diegs wants to merge 1 commit intopontem-network:masterfrom
diegs:master
Open

Remove final solc invocation from solc_download.sh#2
diegs wants to merge 1 commit intopontem-network:masterfrom
diegs:master

Conversation

@diegs
Copy link
Copy Markdown

@diegs diegs commented Mar 28, 2023

$GITHUB_PATH is updated, but that doesn't take effect in the same script that updates it.

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path

This probably works for people who already have e.g. $HOME/.local/bin on their $PATH, but that's not generally true.

@emretepedev
Copy link
Copy Markdown

It's exactly what I needed, thanks!

      - name: Setup Solc
        if: steps.changed-sol-files.outputs.any_changed == 'true'
        uses: pontem-network/get-solc@f67593db4487ac96b4bf8031123a6deefc399b2e
        with:
          version: v${{ env.SOLC_VERSION }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants