Skip to content

Conversation

@ids1024
Copy link
Member

@ids1024 ids1024 commented Jul 17, 2025

It looks like #1475 isn't happening after this, but I need to test a bit more since it's a little hard to reproduce consistently.

This is also meant to fix an issue that can be seen by closing a window (for instance exit in cosmic-term, or super+q) while dragging it still leaving a placeholder in the tiling layout. I'm still not entirely sure why that wasn't causing a crash, but dbeaver was.

This may not be exactly the right way to fix this. I've also noticed an issue where if an output doesn't have any windows, a placeholder isn't created when dragging a window to that output.

Drakulix
Drakulix previously approved these changes Jul 17, 2025
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@ids1024
Copy link
Member Author

ids1024 commented Dec 5, 2025

I guess I didn't get around to looking for better solutions here or adding more fixes to the PR.

But this should be working fine anyway. I guess if @Drakulix thinks it looks fine, we can merge it, and improve the tiling shell code more in later PRs.

  • The first commit here fixes the crash with DBeaver, demonstrated in the video on [BUG] cosmic-comp crashes when attempting to stack DBeaver while it's launching #1475. It seems pretty easy to reproduce with DBeaver if you follow the right steps.
  • The second commit fixes a a visual issue with dragging tiling windows.
    • Previously, on dragging to an output with no windows on it, no placeholder would be created to indicate the drag. While a placeholder would be crated to show where the window would be dragged to on the output it was dragged from, but would disappear but not reappear and moving to another output and back.
    • Now it adds placeholders as expected for workspaces with no windows on them.

@ids1024 ids1024 marked this pull request as ready for review December 5, 2025 23:38
@ids1024 ids1024 requested review from a team December 5, 2025 23:38
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fixes are working and I'm not seeing any regressions.

@jackpot51 jackpot51 merged commit fa88002 into master Dec 9, 2025
6 checks passed
@jackpot51 jackpot51 deleted the tiling-tree_noble branch December 9, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants