Skip to content

#521 Use layout-independent matching for letter shortcuts only#522

Open
deemoun wants to merge 1 commit intopop-os:masterfrom
deemoun:fix-shortcuts
Open

#521 Use layout-independent matching for letter shortcuts only#522
deemoun wants to merge 1 commit intopop-os:masterfrom
deemoun:fix-shortcuts

Conversation

@deemoun
Copy link
Copy Markdown
Contributor

@deemoun deemoun commented Feb 9, 2026

Fixing the issue #521 [Bug] Keyboard shortcuts stop working when switching language to non-latin

Use layout-independent matching for letter shortcuts only.

  • KeyPressed now passes physical_key into shortcut handling.
  • Hybrid matcher added:
    1)ASCII letter binds (A-Z) match by physical key code (KeyA..KeyZ), so Ctrl+A/C/V work on Russian and other non-Latin layouts.
  1. Non-letter binds (named keys, punctuation, digits) keep existing logical-key matching to avoid regressions.
  2. Keeps shortcut behavior stable while fixing locale-related failures for common letter shortcuts.

Tested:

  • After switching to Russian - I am able to use Ctrl-A, Ctrl-C and Ctrl-V
  • After switching back to English - everything still works
  • Able to open a file and shortcuts work there

Haven't observed regressions.

@deemoun
Copy link
Copy Markdown
Contributor Author

deemoun commented Feb 14, 2026

@leviport Any chance this could be reviewed?

Personally, as an international user that pretty much makes the app unusable for those of us who type in layouts other than English.

@leviport leviport requested review from a team February 16, 2026 17:48
@leviport
Copy link
Copy Markdown
Member

Can you resolve those conflicts? I can start testing after that.

@garrettjwilke
Copy link
Copy Markdown

there was a cosmic-comp fix that handles this:

pop-os/cosmic-comp#2067

@deemoun
Copy link
Copy Markdown
Contributor Author

deemoun commented Feb 20, 2026

Thanks. Yep, I will close this PR once I confirm that it's fixed in cosmic-comp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Keyboard shortcuts stop working when using non-US keyboard layouts

3 participants