Skip to content

Implement input method support to COSMIC-edit specific text widgets#528

Closed
kenz-gelsoft wants to merge 2 commits intopop-os:masterfrom
kenz-gelsoft:backport-input-method
Closed

Implement input method support to COSMIC-edit specific text widgets#528
kenz-gelsoft wants to merge 2 commits intopop-os:masterfrom
kenz-gelsoft:backport-input-method

Conversation

@kenz-gelsoft
Copy link
Copy Markdown
Contributor

@kenz-gelsoft kenz-gelsoft commented Feb 12, 2026

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

This is a FYI PR for future reference after the COSMIC team rebased the libcosmic to iced 14.0.

The input method support in iced 14.0 requires text widgets to implement some logic to support input method input. This PR includes this for the cosmic-edit specific text widgets.

This PR depends on my pop-os/libcosmic fork. Please see PRs I opened:

(I will force-push this branch to update my fork to rebase to newer upstream rev)

@kenz-gelsoft kenz-gelsoft changed the title Implement input method support to COSMIC-edit specific text widgets Implement input method support to COSMIC-edit specific text widgets (for iced-rebase branch) Mar 1, 2026
@kenz-gelsoft kenz-gelsoft marked this pull request as ready for review March 1, 2026 01:33
@kenz-gelsoft kenz-gelsoft changed the title Implement input method support to COSMIC-edit specific text widgets (for iced-rebase branch) Implement input method support to COSMIC-edit specific text widgets Mar 1, 2026
@kenz-gelsoft kenz-gelsoft marked this pull request as draft March 1, 2026 01:34
@kenz-gelsoft
Copy link
Copy Markdown
Contributor Author

I rebase this PR onto iced-rebased branch in #539

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant