Conversation
mmstick
approved these changes
Jul 16, 2024
Member
|
I'll push to libcosmic and our apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of fixes for our work-arounds for wgpu's non-existant/broken device selection.
We special case wayland, but we should special case x11 the same way, so e.g. pop-os 22.04. users can use cosmic-store.
Unfortunately the nvidia-xorg-driver doesn't support DRI2, DRI3 or any other way to reliably detect the device node used. So lets rely on the randr-name, which does contain an id and hasn't change ever since this feature was introduce over a decade ago...
(I also have a branch using glutin/egl for detecting the device node, but that is also broken specifically with the nvidia-xorg-driver and nothing else...)
Superseeds #157
Fixes pop-os/libcosmic#512 and pop-os/cosmic-store#73
Tested with system76-power set to hybrid and nvidia, both with
DRI_PRIME=1/__NV_PRIME_RENDER_OFFLOAD=1and no variables. All scenarios display a window with a patched cosmic-store to use this branch.