Skip to content

fix: bounds check pixels #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wash2 wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix: bounds check pixels #294

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f4b056
fix: bounds check pixels
wash2 Mar 19, 2026
50dd63d
fix: use image_width for bounds check
wash2 Mar 19, 2026
51c5171
fix: bounds check padding
wash2 Mar 19, 2026
da6f666
fix: off by one on bounds check
wash2 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions wgpu/src/image/atlas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,24 @@ impl Atlas {
let pad_h = padding.height as usize;
let stride = PIXEL * w;

// bounds check for source pixels to fragment
if pixels.len() < offset + PIXEL * image_width as usize * h {
return;
}

// bounds check for pad_w low / high to fragment
if pad_w > 0
&& (offset + stride < PIXEL
|| offset
+ image_width as usize
* PIXEL
* (h.checked_sub(1).unwrap_or(0))
+ PIXEL
> pixels.len())
{
return;
}

// Copy image rows
for row in 0..h {
let src = offset + row * PIXEL * image_width as usize;
Expand Down
Loading