Oversample small SVG icons before rasterization#317
Closed
anthony-firn wants to merge 1 commit intopop-os:masterfrom
Closed
Oversample small SVG icons before rasterization#317anthony-firn wants to merge 1 commit intopop-os:masterfrom
anthony-firn wants to merge 1 commit intopop-os:masterfrom
Conversation
Author
|
Closing this for now to keep review focused on #318, which is the active renderer-side fix for the dock issue. This can be reopened later if a separate SVG follow-up still makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oversample small SVG icons before rasterization
Summary
Small SVG icons are currently rasterized at their final draw size. That leaves very little coverage information for curved edges and diagonal strokes, which shows up as rough launcher and greeter icons at common 16-32 px sizes.
This change rasterizes small SVGs at 2x size in the shared
wgpuandtiny_skiavector backends, then lets the existing image draw path scale them back down into the requested bounds.Why this shape
Validation
cosmic-launcheragainst the patched renderer path.