fix(ime): flip the candidate position vertically if the bottom edge overflows bottom screen edge#332
Draft
kenz-gelsoft wants to merge 1 commit intopop-os:masterfrom
Draft
Conversation
… well wi…" This reverts commit a9bcb00.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares to fix pop-os/cosmic-comp#2284 for COSMIC apps.
This depends on
cosmic-compPR:Basically pop-os/cosmic-comp#2320 fixes this but we specify the IME cursor rect to 0-height after #291 for workaround cosmic-comp issue, so flipping at screen bottom edge doesn't work correctly.
As pop-os/cosmic-comp#2320 will fix the root cause of #291, we can revert this once pop-os/cosmic-comp#2320 merged and released the
cosmic-compupdate to users.Revert "fix(ime): the candidate window position of fcitx5 which does't work well with winit's set_ime_cursor_area()"
Reverts #291