Conversation
crawfxrd
force-pushed
the
version-release
branch
4 times, most recently
from
b0c76f0 to
3580e3f
Compare
jacobgkau
approved these changes
Sep 26, 2025
Member
There was a problem hiding this comment.
My only concern with this would be that we're not great about updating debian/changelog in most of our repos. As long as we can keep doing that consistently for this repo, this seems simpler than the two-script setup (and safer, as it doesn't require someone to push straight to master after every PR). The CI test appears to be working.
jacobgkau
requested changes
Sep 26, 2025
Cut the cruft for making releases. - Use debchange for generating the `debian/changelog` entry instead of manually creating it through a Python script - Jenkins CI will tell us if building the package fails, so don't require doing it when making a release - Run tests as part of CI instead of when making a release Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
version-release
branch
from
3580e3f to
5561a96
Compare
Member
Author
|
I've additionally documented it should be a signed tag. |
jacobgkau
previously approved these changes
Sep 29, 2025
jacobgkau
approved these changes
Oct 14, 2025
Member
|
@jackpot51 What do you think of this? |
8 tasks
jackpot51
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cut the cruft for making releases.
debian/changelogentry instead of manually creating it through a Python scriptNote: Because GHA runs headless, GTK tests are not run.