Skip to content

Remove switchable graphics code#463

Open
Drakulix wants to merge 1 commit intomasterfrom
suspend-nvidia_noble
Open

Remove switchable graphics code#463
Drakulix wants to merge 1 commit intomasterfrom
suspend-nvidia_noble

Conversation

@Drakulix
Copy link
Copy Markdown
Member

This drops all the graphics related code, so that users don't accidentally write config files using the system76-power cli tool, that will not work with COSMIC.

Special care has been taken to keep the bonw15-hack and not enable the fine-grained power-management on that machine. (Though this might only happen after first boot, but that isn't worse than the current solution.)

This should only be merged when master_jammy has been merged off to not break switching on 22.04 installs.

Comment thread src/daemon/mod.rs Outdated
@Drakulix Drakulix force-pushed the suspend-nvidia_noble branch from 2e60b44 to 4332c48 Compare August 29, 2025 16:46
@jacobgkau jacobgkau requested review from a team September 2, 2025 22:25
@crawfxrd
Copy link
Copy Markdown
Member

NVreg_DynamicPowerManagement=0x01 can be set by a quirk in system76-driver (pop-os/system76-driver#335), allowing that to be dropped as well.

@Drakulix
Copy link
Copy Markdown
Member Author

NVreg_DynamicPowerManagement=0x01 can be set by a quirk in system76-driver (pop-os/system76-driver#335), allowing that to be dropped as well.

Added a commit to drop that as well and rebased on current master.

@jacobgkau
Copy link
Copy Markdown
Member

Since we want #468 on all branches, I think it makes sense to look at that one first, merge it (when ready), then split the branches and look at this.

@jacobgkau
Copy link
Copy Markdown
Member

This is working fine on a random hybrid system (addw5) in my testing so far. We may need to find a bonw15 around the lab to confirm its hack still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants