Remove setting NVreg_DynamicPowerManagement#465
Merged
Conversation
Member
Author
|
ubuntu-drivers-common is explicitly setting the value to 0x02 in Other things
This would remove the need for custom modprobe rules for discrete and hybrid graphics modes. |
d3565ab to
5d30a03
Compare
For a while now, this has had an auto value (0x03) that is the default. Explicitly setting it is only required if the auto value does not work. Such cases can be handled in system76-driver as a quirk. Signed-off-by: Tim Crawford <tcrawford@system76.com>
5d30a03 to
8eca642
Compare
jacobktm
approved these changes
Sep 23, 2025
jacobktm
left a comment
There was a problem hiding this comment.
This does resolve the GSP crash in the addw4 and I also did some testing in an oryp12, bonw16, and gaze20 and everything works normally in those systems.
jackpot51
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a while now, this has had an auto value (0x03) that is the default. Explicitly setting it is only required if the auto value does not work. Such cases can be handled in system76-driver as a quirk.
Requires: pop-os/system76-driver#335