Merged
Conversation
This was added as a last resort to defend against ghost protections, but chose to cancel the event instead of just cleaning it up. While this protects against accidental deletion of protected blocks, this event has strange side effects at times and has caused more trouble than it is worth. This patch instead cleans up destroyed protections, without preventing their destruction. Fixes pop4959#251 Fixes pop4959#248
pop4959
approved these changes
Feb 5, 2026
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added as a last resort to defend against ghost protections, but chose to cancel the event instead of just cleaning it up. While this protects against accidental deletion of protected blocks, this event has strange side effects at times and has caused more trouble than it is worth.
This patch instead cleans up destroyed protections, without preventing their destruction.
Fixes #251
Fixes #248
Future patches could add the additional handling from
BlockBreakEvent.