fix: Remove array support from inferType. #1050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was always broken, because the oid of a boolean[] is not the same as the oid of a boolean, and AFAICT inferType was resolving "boolean[] --> the oid of a boolean" without any attempt to translate over to the `boolean[]` oid. There's talk of removing `inferType` entirely, which would have to wait until v4, but I think if this array-based support has always been broken (afaiu?), we can just remove it immediately in a v3 bug fix release. Fixes porsager#471
|
Disclaimer I haven't run the tests, b/c am waiting for the workflow to be approved (i.e. I haven't looked into getting the tests to run locally--would be great to have a CONTRIBUTING.md tldr). |
porsager
force-pushed
the
master
branch
2 times, most recently
from
4fd011e to
a92f470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was always broken, because the oid of a boolean[] is not the same as the oid of a boolean, and AFAICT inferType was resolving "boolean[] --> the oid of a boolean" without any attempt to translate over to the
boolean[]oid.There's talk of removing
inferTypeentirely, which would have to wait until v4, but I think if this array-based support has always been broken (afaiu?), we can just remove it immediately in a v3 bug fix release.Fixes #471