-
Notifications
You must be signed in to change notification settings - Fork 2
Watermelon and Steak Task #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eated enumerations for all assets, and added rendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on this PR! I've tested out all the environments and they look fine. Just some minor comments, particularly about removing changes that do not belong in this PR to prevent any merge conflicts in the future, and to add some predicates. Do let me know if you have any questions! For future PRs, also please include a screen recording of the actions instead of screenshots.
Also, any idea what the .DS_store binary file in the assets file is? If it is not necessary please remove it.
| } | ||
| }, | ||
| { | ||
| "name": "pan-fry", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this from this PR since it is not part of this PR, so that we have less merge conflicts in the future
| "sfx": [] | ||
| }, | ||
| { | ||
| "name": "pan-fry", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar with this action, remove it for this PR, especially since we changed the pan and pan-fry action in the fried eggs PR
| }, | ||
| { | ||
| "name": "ispan", | ||
| "param_types": ["item"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this predicate, and remember to include the "iswatermelon" and "issteak" predicates, since we will need those predicates for when we make recipes and check if customers' orders have been satisfied
Overview
We implemented slicing watermelons and cooking steak.
Changes Made
Test Coverage
Screenshots