Skip to content

Conversation

@YottaYocta
Copy link

Overview

We implemented slicing watermelons and cooking steak.

Changes Made

  • added new assets for watermelon, watermelon & slices, uncooked steak, cooked steak
  • implemented actions for slicing watermelons and cooking steak

Test Coverage

  • we created three new environments to test if these new tasks worked. Two test a single item (steak and watermelon respectively) while the third tests both in the same environment

Screenshots

image

Copy link
Contributor

@lsuyean lsuyean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this PR! I've tested out all the environments and they look fine. Just some minor comments, particularly about removing changes that do not belong in this PR to prevent any merge conflicts in the future, and to add some predicates. Do let me know if you have any questions! For future PRs, also please include a screen recording of the actions instead of screenshots.

Also, any idea what the .DS_store binary file in the assets file is? If it is not necessary please remove it.

}
},
{
"name": "pan-fry",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this from this PR since it is not part of this PR, so that we have less merge conflicts in the future

"sfx": []
},
{
"name": "pan-fry",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar with this action, remove it for this PR, especially since we changed the pan and pan-fry action in the fried eggs PR

},
{
"name": "ispan",
"param_types": ["item"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this predicate, and remember to include the "iswatermelon" and "issteak" predicates, since we will need those predicates for when we make recipes and check if customers' orders have been satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants