pctx-py: add ty type checking, split Makefile, refine @tool#75
Merged
eliasposen merged 2 commits intomainfrom May 8, 2026
Merged
pctx-py: add ty type checking, split Makefile, refine @tool#75eliasposen merged 2 commits intomainfrom
eliasposen merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tyas a dev dep, fixed all type errors it surfaced in _client.py, _convert.py, _tool.py, _websocket_client.py, descriptions/init.py, and models.py. Includes a real bug fix in_websocket_client.execute_typescript—ExecuteCodeParams(style=disclosure)was silently dropped by pydantic, so the websocket path always usedCATALOGregardless of the caller'sdisclosurearg.install,lint,typecheck, andcheck(lint+typecheck+test) targets.lintjob tocheck, added aType checkstep, and gated the static-analysis steps on!cancelled() && install.outcome == 'success'so a single CI run surfaces all formatting/lint/typecheck issues at once.@tooldecorator polish:input_schemaaccepts a Pydantic BaseModel or JSON Schema dict;output_schemaaccepts a Python type / typing construct or JSON Schema dict;nameis now keyword-only.Test plan
make -C pctx-py checkpasses locallycheckjob runs format / lint / typecheck and surfaces all failures in one runtestmatrix passes on 3.10–3.13disclosurearg now reaches the websocket execute path (fixed bug)🤖 Generated with Claude Code