PB-8335 | Fixes #664 - Support Multi instances of px-central - multi Helm releases#665
Open
abdennour wants to merge 3 commits intoportworx:masterfrom
Open
PB-8335 | Fixes #664 - Support Multi instances of px-central - multi Helm releases#665abdennour wants to merge 3 commits intoportworx:masterfrom
abdennour wants to merge 3 commits intoportworx:masterfrom
Conversation
abdennour
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
it's suffixing all cluster-wide resources ( clusterrole and clusterrolebinding) with
{{.Release.Namespace}}, so px-central can be deployed many times in the same cluster within different namespaces.Which issue(s) this PR fixes (optional)
Closes #664
Special notes for your reviewer:
N/A