Skip to content

fix(pkg-r): Use database-agnostic SQL for SQL Server compatibility #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpsievert wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

fix(pkg-r): Use database-agnostic SQL for SQL Server compatibility #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg-r/R/DBISource.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ DBISource <- R6::R6Class(
self$table_name <- table_name

# Store original column names for validation
# Use WHERE 1=0 instead of LIMIT 0 for SQL Server compatibility
private$colnames <- colnames(DBI::dbGetQuery(
conn,
sprintf(
"SELECT * FROM %s LIMIT 0",
"SELECT * FROM %s WHERE 1=0",
DBI::dbQuoteIdentifier(conn, table_name)
)
))
Expand Down Expand Up @@ -205,12 +206,14 @@ get_schema_impl <- function(
text_columns <- character(0)

# Get sample of data to determine types
# Use dbFetch(n=1) instead of LIMIT 1 for SQL Server compatibility
sample_query <- paste0(
"SELECT * FROM ",
DBI::dbQuoteIdentifier(conn, table_name),
" LIMIT 1"
DBI::dbQuoteIdentifier(conn, table_name)
)
sample_data <- DBI::dbGetQuery(conn, prep_query(sample_query))
rs <- DBI::dbSendQuery(conn, prep_query(sample_query))
sample_data <- DBI::dbFetch(rs, n = 1)
DBI::dbClearResult(rs)

for (col in columns) {
col_class <- class(sample_data[[col]])[1]
Expand Down