Skip to content

Fix Formatting Issues with Skills Section #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Furqan136
Copy link

Fixes the following issues with cvskills:

  1. Text overflows to the margins
    1.1 Fixed by defining the width of columns in cvskills environment
  2. Formatting issue when cvskills span multiple lines
    2.1 Fixed by changing the column formatting from vertically center aligned to vertically top aligned
    2.2 This change does not impact formatting of any other part of the CV

Issue:
Issue

Fixed:
Fixed

Signed-off-by: Muhammad Furqan <mfurqan1024@gmail.com>
Changes tabular alignment from middle to top
This fixes the alinment issue when CVSkills overflow one line
Has no impact on rest of the CV's alignment

Signed-off-by: Muhammad Furqan <mfurqan1024@gmail.com>
@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Sep 13, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

@NicoHood
Copy link

This does not quite work for me:

Before:
image

After:
image

Now the left side it made really small.

@Germano0
Copy link

Germano0 commented May 2, 2025

My personal is feedback is:
I tested both #489 and #530, the pull requests that fix #436
I prefer #530, in particular for the allignment of the % Category column position (the bold column on the left).
Here to screenshots

#489
489

#530
530

@Furqan136
Copy link
Author

@NicoHood / @Germano0 I had intentionally kept the left column small to let it's content wrap into the next line, as it is supposed to have only 1-2 word names for the category. As you can see in your screenshot, the dynamic formatting also doesn't look good for long category names. As for @NicoHood 's use case, I did not consider other languages. For now, you can increase the size of the category column on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants