Set default branch to main for clone creation #267
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a clone without specifying a branch, both the UI and API now default to "main" branch instead of using the first available branch or the snapshot's branch. UI: Changed to prioritize "main" branch when selecting default. API: Changed default from snapshot.Branch to branching.DefaultBranch. Related: https://gitlab.com/postgres-ai/database-lab/-/issues/662
Adds TestDefaultBranch to ensure the DefaultBranch constant remains set to "main" and doesn't regress.
Adds TestDefaultBranchForCloneCreation with multiple test cases: - Empty branch defaults to main (regardless of snapshot branch) - Explicit branch names are preserved Removes simple constant test in favor of behavior test.
When a specific snapshot is requested but no branch is specified, use the snapshot's branch to maintain consistency. Only default to "main" when neither branch nor snapshot are specified. - No branch + no snapshot → default to main - No branch + snapshot specified → use snapshot's branch - Explicit branch → use specified branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
API (
engine/internal/cloning/base.go):UI (
ui/packages/shared/pages/CreateClone/index.tsx):Tests (
engine/internal/cloning/base_test.go):TestDefaultBranchForCloneCreationcovering all branch selection scenariosBehavior
Fixes: https://gitlab.com/postgres-ai/database-lab/-/issues/662