Claude/add e2e Grafana tests #11
Open
+952
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayS
changed the title
Add end-to-end tests to verify the Grafana monitoring stack correctly extracts and displays basic PostgreSQL metrics: - tests/grafana/test_grafana_metrics.py: Python test that verifies: - Database size metric (pgwatch_db_size_size_b) - Transaction commit/rollback metrics - Tuple read/write metrics - Grafana datasources and dashboards are loaded - Dashboard queries execute correctly via Grafana proxy - tests/grafana/run_test.sh: Bash runner for local testing with optional CI mode that starts the monitoring stack - .gitlab-ci.yml: New grafana:e2e:dind job that runs on main and feature/* branches using Docker-in-Docker
Add verify_dashboard_panels_data() that: - Executes actual dashboard panel queries through Grafana API - Validates data is returned (not empty) - Checks values meet minimum thresholds (e.g., DB size > 1MB) - Verifies transaction commits, tuples returned/inserted are non-zero This ensures dashboards would actually visualize real data, not just that metrics exist in Prometheus.
NikolayS
force-pushed
the
claude/add-e2e-grafana-tests-qcdV0
branch
from
91423e0 to
d70cfdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.