feat: tidy repo and synchronize deps#6
Conversation
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
| }), | ||
| ); | ||
|
|
||
| await bench.warmup(); |
There was a problem hiding this comment.
warmup has been moved to an optional argument, see instantiation of bench above
| { | ||
| "name": "benchmarks", | ||
| "version": "0.1.0", | ||
| "private": true, |
There was a problem hiding this comment.
made this private so that it does not get published. gave it the same version as the rest of the monorepo for consistency
| test: { | ||
| browser: { | ||
| provider: "playwright", | ||
| provider: playwright(), |
There was a problem hiding this comment.
the api for setting up this type of test has changed since the old version of vite that was used previously. this config produces the same result.
| "scripts": { | ||
| "build": "tsc", | ||
| "test": "PG_CONNECTION_STRING=postgresql://postgres:password@localhost:5555/analytics vitest run" | ||
| "test:pg": "PG_CONNECTION_STRING=postgresql://postgres:password@localhost:5555/analytics vitest --run ./**/*.test.ts" |
There was a problem hiding this comment.
renamed to test:pg so that this test is not run by the normal test-ci command in the check commit workflow
| environment: "node", | ||
| testTimeout: 5000, | ||
| setupFiles: "./test/vitest.setup.ts", | ||
| poolOptions: { |
There was a problem hiding this comment.
I am not so sure what this was doing before, but this option has been removed from the vitest config in the current version. it looks to me like the tests all pass in a reasonable amount of time as expected.
There was a problem hiding this comment.
This was here in the case that we used a single PG db backend in test (like test:pg).
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
2 participants
There were some dependency related issues happening in places where we import code from this repository in the main powerhouse monorepo.
There was also no linting/formatting set up in the repo, and no test step in the ci.
I have added a new release workflow which will publish the dependencies in lockstep with each other, so there will no longer be issues with peer dependencies / mismatched versions.
I have fixed the above and added the other pieces. Everything builds and compiles, all tests pass.