Updated simple_config for change of directory#24
Open
akshephard wants to merge 1 commit intopowerjg:masterfrom
Open
Updated simple_config for change of directory#24akshephard wants to merge 1 commit intopowerjg:masterfrom
akshephard wants to merge 1 commit intopowerjg:masterfrom
Conversation
Changed broken command due to the removal of the tutorials directory.
powerjg
requested changes
May 23, 2018
Owner
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I think the code is OK as it is, but adding something like what I wrote as a comment below would make the prose clearer. Could you update this PR for that?
| @@ -251,7 +251,7 @@ So, we can simply run gem5 from the root gem5 directory as: | |||
|
|
|||
Owner
There was a problem hiding this comment.
How about "So, we can simply run gem5 from the root gem5 directory as shown below. configs/tutorial/simple.py is the path to the config file we wrote above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed broken command due to the removal of the tutorials directory.