Added Regression system to Extending gem5 part#27
Open
fusiled wants to merge 2 commits intopowerjg:masterfrom
Open
Added Regression system to Extending gem5 part#27fusiled wants to merge 2 commits intopowerjg:masterfrom
fusiled wants to merge 2 commits intopowerjg:masterfrom
Conversation
added 2 commits
May 29, 2018 12:39
Added first version about the regression system. Basically it explains how to add a test-case and adding categories and/or modes
… executable + small fix on the destination from which you copy the output in order to generate the reference for the test
Owner
|
Hi Matteo, Thanks for the contribution! It's definitely important to document how to use the testing and regression system!! I'm going to hold off on accepting this PR right now because I'm hoping to replace the regression system with a more user-friendly interface. You can see the set of patches here: https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged) starting with https://gem5-review.googlesource.com/c/public/gem5/+/4880/6. If you have time to review those patches, it would be very helpful. After those get in, we can iterate on this to make it work for the new testing system. |
Author
|
Hi Jason,
That's completely fine. Actual regression testing is really cumbersone and
it's not very clear how to use by looking at the gem5 wiki. Since this book
is the best resource online, i think it was worth contribute to it. As soon
a i can i'll take a look to the patches.
…On Tue, May 29, 2018, 19:11 Jason Lowe-Power ***@***.***> wrote:
Hi Matteo,
Thanks for the contribution! It's definitely important to document how to
use the testing and regression system!!
I'm going to hold off on accepting this PR right now because I'm hoping to
replace the regression system with a more user-friendly interface. You can
see the set of patches here:
https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged)
starting with https://gem5-review.googlesource.com/c/public/gem5/+/4880/6.
If you have time to review those patches, it would be *very* helpful.
After those get in, we can iterate on this to make it work for the new
testing system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACdbXkg3aY7X6jDtFrGJMZIY8ILEJHV5ks5t3YE6gaJpZM4URu5q>
.
|
Owner
|
Cumbersome is an understatement :). Thanks for taking a stab at the
documentation!
On Tue, May 29, 2018 at 10:25 AM Matteo Maria Fusi <notifications@github.com>
wrote:
… Hi Jason,
That's completely fine. Actual regression testing is really cumbersone and
it's not very clear how to use by looking at the gem5 wiki. Since this book
is the best resource online, i think it was worth contribute to it. As soon
a i can i'll take a look to the patches.
On Tue, May 29, 2018, 19:11 Jason Lowe-Power ***@***.***>
wrote:
> Hi Matteo,
>
> Thanks for the contribution! It's definitely important to document how to
> use the testing and regression system!!
>
> I'm going to hold off on accepting this PR right now because I'm hoping
to
> replace the regression system with a more user-friendly interface. You
can
> see the set of patches here:
>
https://gem5-review.googlesource.com/q/topic:%22test-framework-WIP%22+(status:open%20OR%20status:merged)
> starting with
https://gem5-review.googlesource.com/c/public/gem5/+/4880/6.
>
> If you have time to review those patches, it would be *very* helpful.
>
> After those get in, we can iterate on this to make it work for the new
> testing system.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#27 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ACdbXkg3aY7X6jDtFrGJMZIY8ILEJHV5ks5t3YE6gaJpZM4URu5q
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGsHHh3v0gBZz3iXAjsvKWLEZs9cP5dks5t3YRngaJpZM4URu5q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a section in which is explained how to extend the regression system.