revert IMenu RefreshPlatform to fix 1.5.97 ctd #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Reworks IMenu::RefreshPlatform() to avoid a version-specific crash (CTD) affecting custom-derived IMenu classes on Skyrim 1.5.97, while keeping behavior working on 1.6.1170.
Changes:
- Replaces the relocation-based call to the game’s
IMenu::RefreshPlatformwith an in-library implementation that updates Scaleform platform state and cursor behavior. - Adds a null-guard for
InterfaceStrings::GetSingleton()before usingcursorMenu.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous change appears to cause CTD's for custom derived IMenu classes just on 1.5.97 (1.6.1170 was fine)
With reversion RefreshPlatform via IMenu appears to be find on 1.5.97 and 1.6.1170.