Skip to content

Fix null values in CRUD entries being reported as strings #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Fix null values in CRUD entries being reported as strings #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3a9591
Fix null values in CRUD entries reported as strings
simolus3 Aug 25, 2025
5a1742d
Reformat
simolus3 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
to upload multiple transactions in a batch.
* Fix modifying severity of the global Kermit logger
* Add `PowerSync` tag for the logs
* Fix `null` values in CRUD entries being reported as `"null"` strings.
* [INTERNAL] Added helpers for Swift read and write lock exception handling.

## 1.4.0
Expand Down
5 changes: 5 additions & 0 deletions core/src/commonIntegrationTest/kotlin/com/powersync/CrudTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ class CrudTest {
)
batch.crud[0].previousValues shouldBe null

batch.crud[1].opData shouldBe
mapOf(
"a" to "te\"xt",
"b" to null,
)
batch.crud[1].opData?.typed shouldBe
mapOf(
"a" to "te\"xt",
Expand Down
7 changes: 4 additions & 3 deletions core/src/commonMain/kotlin/com/powersync/db/crud/SerializedRow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import kotlinx.serialization.json.JsonElement
import kotlinx.serialization.json.JsonNull
import kotlinx.serialization.json.JsonObject
import kotlinx.serialization.json.JsonPrimitive
import kotlinx.serialization.json.contentOrNull
import kotlinx.serialization.json.jsonPrimitive
import kotlin.experimental.ExperimentalObjCRefinement
import kotlin.native.HiddenFromObjC
Expand Down Expand Up @@ -47,11 +48,11 @@ internal class SerializedRow(

private data class ToStringEntry(
val inner: Map.Entry<String, JsonElement>,
) : Map.Entry<String, String> {
) : Map.Entry<String, String?> {
override val key: String
get() = inner.key
override val value: String
get() = inner.value.jsonPrimitive.content
override val value: String?
get() = inner.value.jsonPrimitive.contentOrNull
}

private class TypedRow(
Expand Down
Loading