Skip to content

fix: handleNotify goroutine checks s.done before refreshZone #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poyrazK merged 1 commit into from
May 7, 2026
+9 −0
Merged

fix: handleNotify goroutine checks s.done before refreshZone #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/dns/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,7 @@ func (s *Server) handleNotify(ctx context.Context, request *packet.DNSPacket, cl
// Trigger async refresh if it's a slave zone
if !s.DisableAsync {
go func(zoneName string) {
// Check for cancellation or shutdown before starting long-running operations.
select {
case <-ctx.Done():
return
Expand All @@ -1327,6 +1328,14 @@ func (s *Server) handleNotify(ctx context.Context, request *packet.DNSPacket, cl
return
}
if zone != nil && zone.Role == "slave" {
// Check again before refresh to avoid unnecessary work during shutdown.
select {
case <-ctx.Done():
return
case <-s.done:
return
default:
}
s.refreshZone(ctx, zone)
}
}(request.Questions[0].Name)
Expand Down
Loading