fix(repos/postgres): return empty slice instead of nil when no databases found#486
fix(repos/postgres): return empty slice instead of nil when no databases found#486
Conversation
…ses found When scanDatabases returns nil (no rows), JSON marshal produces "null" instead of "[]". Initialize the slice with make() so empty results marshal as empty array. Fixes #459
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes
cloud db listreturningnullin JSON mode when no databases exist, instead of[].Changes
Changed
scanDatabasesininternal/repositories/postgres/database_repo.goto initialize the slice withmake()instead ofvar:Root Cause
When Go's
encoding/jsonmarshals anilslice, it producesnull. An empty initialized slice produces[].Test Plan
go build ./internal/repositories/postgres/...— passesgo test -v ./internal/repositories/postgres/...— all tests passFixes
Fixes #459