Skip to content

fix: libvirt instance rm error message (#435)#490

Open
poyrazK wants to merge 1 commit intomainfrom
fix/libvirt-instance-rm-435
Open

fix: libvirt instance rm error message (#435)#490
poyrazK wants to merge 1 commit intomainfrom
fix/libvirt-instance-rm-435

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented May 7, 2026

Summary

Test plan

  • go build ./... passes
  • go test ./internal/core/services/... -run "Terminate" passes

Fixes #435

…"container"

Follows the same pattern as PR #484 (StopInstance fix for #430).
The removeInstanceContainer error now says "failed to remove {backend} instance"
instead of hardcoded "failed to remove container".

Fixes #435
Copilot AI review requested due to automatic review settings May 7, 2026 18:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 15 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c3c404d9-4c53-449e-b52b-9433ef43a8c7

📥 Commits

Reviewing files that changed from the base of the PR and between 5faabcc and 987be27.

📒 Files selected for processing (2)
  • internal/core/services/instance.go
  • internal/core/services/instance_unit_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/libvirt-instance-rm-435

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI instance rm fails for libvirt instances - 'failed to remove container'

2 participants