Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
IP-7068 [compose] dishka 기반 auto-wiring route class 팩토리 제공
배경
목표
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
Walkthroughcompose.fastapi에 Dishka 통합용 엔트리인 변경 사항
시퀀스 다이어그램sequenceDiagram
participant Client as Client
participant FastAPI as FastAPI App
participant Route as InjectedDishkaRoute
participant Container as Dishka Container
participant Handler as Endpoint Handler
Client->>FastAPI: HTTP 요청
FastAPI->>Route: 라우트 핸들러 호출
Route->>Container: 의존성(파라미터) 요청 (resolve)
Container-->>Route: 인스턴스 반환
Route->>Handler: 핸들러 호출 (주입된 인자 포함)
Handler-->>Route: 응답 반환
Route-->>FastAPI: 응답 전달
FastAPI-->>Client: HTTP 응답
예상 코드 리뷰 소요 시간🎯 3 (Moderate) | ⏱️ ~20 minutes 시
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
목적
dependency-injector의 명시적 와이어링으로 인한 연쇄 수정 문제를 해소하기 위해, fastapi_example에 있던 dishka 기반 auto-wiring route class 팩토리를 compose 모듈로 이동하여 공통으로 사용할 수 있도록 제공
변경 사항
compose.fastapi.dishka모듈 추가injected_route(container)팩토리: container의 registry에서 해결 가능한 타입을 자동으로FromDishka[Type]으로 변환하는 route class 생성src/dependency/routing.py삭제,compose.fastapi.injected_route직접 사용으로 전환Summary by CodeRabbit
릴리스 노트
신기능
테스트
의존성