Conversation
IP-7079 [compose] 내부 유틸리티 함수의 flat/recursive 의도를 이름에 반영
배경
목표
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (7)
Walkthrough
Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
목적
Evaluable클래스와evaluate함수의 이름이 flat/recursive 차이를 드러내지 않아 혼동 가능성이 있으므로,evaluate/deep_evaluate함수 쌍으로 통일하여 의도를 명확히 표현변경 사항
Evaluable클래스를deep_evaluate함수로 전환Evaluable(x).expression()보일러플레이트를deep_evaluate(x)호출로 단순화base.py,stage.py,raw.py,array_expression.py,conditional.py의 모든Evaluable참조를deep_evaluate로 변경Summary by CodeRabbit
릴리스 노트