This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Fixed NPE in getFromMap with String and HaHosts#39
Open
juicegit wants to merge 6 commits intoppat:masterfrom
Open
Fixed NPE in getFromMap with String and HaHosts#39juicegit wants to merge 6 commits intoppat:masterfrom
juicegit wants to merge 6 commits intoppat:masterfrom
Conversation
juicegit
changed the title
Following the example in https://www.rabbitmq.com/ssl.html. Added support for the ability to verify rabbit server certs.
jnioche
reviewed
May 9, 2017
Contributor
jnioche
left a comment
jnioche
left a comment
There was a problem hiding this comment.
Got exactly the same issue: any reason not to merge this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to setup a spout that does not use HA, the code for checking for HA throws a NPE in this code here since it assumes that any key looked up in the map has a value. For HA Hosts, the only acceptable value other than hosts is null.