-
Notifications
You must be signed in to change notification settings - Fork 459
Fix LMB hold when hovering with tablet pen #6701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes an issue where LMB would be released immediately when the pen is in hover range. Added pen pressure hysteresis, may be needed.
Fixes an issue where LMB would be released immediately when the pen is in hover range. Added pen pressure hysteresis, may be needed.
| Precision = 0.005f, | ||
| }; | ||
|
|
||
| public BindableFloat PressureHysteresis { get; } = new BindableFloat(0.0f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the kind of thing we can hard-code instead? I feel like we should be able to come up with a pretty good value which will work for 99.999% of users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game already has a pressure threshold slider. Maybe we should add a similar pressure hysteresis slider for user customization or add it as an experimental feature? Maybe set the default value to 0.05 or leave it at 0 to not change the existing logic.
In the current version, the pen always sends the LMB state. Is this to prevent hangs in the held state, or is there another reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the public PressureHysteresis setting / API and hard-coded a small internal hysteresis band (0.05) to avoid chatter around the existing PressureThreshold. Main fix remains: only enqueue pen button state on changes, plus explicit release when tablet disappears.
Stop continuously propagating pen LMB state; use edge-only press/release with a small internal hysteresis and release on tablet disconnect.
Fixes an issue where LMB would be released immediately when the pen is in hover range. Added pen pressure hysteresis, may be needed.
Here are links to the reported issues.
https://osu.ppy.sh/community/forums/topics/2089384
ppy/osu#27310