Updated Beatmap search query parsing #12364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
changed the title
notbakaneko
changed the title
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
from
d6fc079 to
95c09fa
Compare
nanaya
requested changes
Aug 26, 2025
| throw new Exception('$clause should be associative array or Queryable.'); | ||
| } | ||
|
|
||
| public static function tokenize(string $query): array |
Collaborator
There was a problem hiding this comment.
I don't think this is the expected result? (also, tokenise?)
> QueryHelper::tokenize('"hello" "world"')
= [
"exclude" => [],
"include" => [
""hello" world"",
],
]
| ]; | ||
|
|
||
| $mode = 'include'; | ||
| $token = strtok($query, ' '); |
Collaborator
There was a problem hiding this comment.
should probably at least replace all kind of spaces to this normal space first. Full width space is usually expected to act as normal separator in this context
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
3 times, most recently
from
baf618a to
c0b37a0
Compare
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
2 times, most recently
from
bd43fdf to
239697d
Compare
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
from
239697d to
71b7049
Compare
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
from
71b7049 to
38c0a78
Compare
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
from
38c0a78 to
ef7643b
Compare
Collaborator
Author
|
Making test updates |
Also fix spelling
…rently too flakey. Keep the updated query string logic. negative boost should be safe to test... maybe
Added note and skip asserting order for relevancy tests.
notbakaneko
force-pushed
the
feature/beatmapset-search-keyword-parse
branch
from
ef7643b to
c25d1a5
Compare
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beatmap search query string parsing portion of #12148
Removes all usages of
QueryHelper::queryString/simple_query_stringinBeatmapsetSearchwhich isn't suitable for our supported syntax without more contortions and parsing to make it fit, at which point we might as well just parse it ourselves.tokenisetest