-
Notifications
You must be signed in to change notification settings - Fork 409
BBcode [right] align #12594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
BBcode [right] align #12594
Conversation
|
Also seen in #12431. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources/css/bbcode.less
Outdated
| .js-spoilerbox { | ||
| display: inline-block; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably reference .bbcode-spoilerbox instead.
753e642 to
ec62038
Compare
|
It happens specifically when you put a long, multiline paragraph of text in there, as you can see on my screenshot I've thrown a bunch of lorem ipsum into the spoilerbox. |
nanaya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think making a bunch of those elements inline instead would work better. And [center] inside of [right] should have the expected effect (same with the other way)




supersedes #12431
resolves #12356
in #12431, kama talks about rewriting the
<center>implementation since it is deprecated but i don't know if i should do something about it. Quick question, if this gets merged, should i update the documentation in https://github.com/ppy/osu-wiki/blob/master/wiki/BBCode/en.md ?Tested for main audio, spoilerboxes, videos results:
