-
Notifications
You must be signed in to change notification settings - Fork 409
Adjust "account not in good standing" display thresholds #12626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
LiquidPL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already pretty good, there's just one thing to change
|
Thanks for the feedback, applied all requested changes:
|
LiquidPL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for taking the time to implement my idea! One minor point of criticism, though: It's redundant (and in my opinion, slightly counterproductive) to show the "bad standing" warning if a user has an active silence because:
|
|
An active silence shouldn't hide the account standing warning either, since the warning should be independent of whether the silence is active. Please remove lines 97 to 102. |
nanaya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and might as well squash the commits
97668ca to
e73b963
Compare
Resolves #12533
This PR implements logic to hide the "bad standing" warning for minor infractions, as discussed in the issue
Key changes:
Includes PHPUnit tests covering all logic branches