Skip to content

Conversation

@002love
Copy link
Contributor

@002love 002love commented Dec 27, 2025

Resolves #12533

This PR implements logic to hide the "bad standing" warning for minor infractions, as discussed in the issue

Key changes:

  • warning is hidden for regular users if recent silences are <24h and inactive
  • moderators still see the warning if any history exists (preserving visibility for staff)
  • threshold of 3+ infringements triggers the warning regardless of length

Includes PHPUnit tests covering all logic branches

Copy link
Contributor

@LiquidPL LiquidPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already pretty good, there's just one thing to change

@002love
Copy link
Contributor Author

002love commented Dec 28, 2025

Thanks for the feedback, applied all requested changes:

  • renamed hasBadStanding to inBadStanding in the model and moved the moderator logic to the UserTransformer
  • refactored isAfter() to isFuture()
  • cleaned up config_set calls in unit tests

Copy link
Contributor

@LiquidPL LiquidPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Userlog2
Copy link
Contributor

Userlog2 commented Dec 30, 2025

Thanks for taking the time to implement my idea!

One minor point of criticism, though: It's redundant (and in my opinion, slightly counterproductive) to show the "bad standing" warning if a user has an active silence because:

  1. There is another equally obvious info message showing that the user is silenced,
  2. The user is silenced and feeling the full effects of it; an extra red text isn't going to make it much more noticeable when they already can't chat, comment, etc.
  3. It makes the purpose of the "bad standing" warning less clear. It's intended for severe/repeat offenders, so flashing it at a minor chat offender for 5 minutes could be a bit confusing.

@Userlog2
Copy link
Contributor

Userlog2 commented Jan 5, 2026

An active silence shouldn't hide the account standing warning either, since the warning should be independent of whether the silence is active. Please remove lines 97 to 102.

Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and might as well squash the commits

@002love 002love force-pushed the fix/account-standing-thresholds branch from 97668ca to e73b963 Compare January 8, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the "Account not in good standing" text appear only when recent infringements are bad enough

5 participants