Skip to content

Conversation

@LiquidPL
Copy link
Contributor

Prerequisite for ppy/osu#32584.

I've noticed that there was already a TeamStatisticsTransformer that is to my knowledge used in the team rankings pages. It is inconsistent with the API conventions in some places (specifically using ruleset IDs instead of string values). I figure it's not part of the public API, but I didn't want to refactor it before confirming first.

Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • newer json has ruleset id instead of name
  • it's the User/BeatmapCompact transformer that need rename, not the other way around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants