Use different osu difficulty hit object types in different cases #36290
Conversation
|
Seems extremely redundant. Object types are already being checked by |
The reason for this is because all current evaluators expect all objects to be tappable. And if it's not (like in spinner case) - it breaks them. In order to make it not break - several objects after a spinner don't have any difficulty at all. This means that adding a spinner to the map simply removes the pp from the next 2 objects. For maps like Tsuropettan it makes it loose 0.6 stars (from 5.6 to 5.0). The easiest solution is just removing spinners from ODHO completely (see - #32716). But this means that it wouldn't be possible to properly evaluate spinner difficulty like in Apollo spinner rework (that has the same problem of removing difficulty from objects after the spinner). So this solution instead makes so all evaluators get what they want. The issue in itself is not very major on practice due to small amount of affected maps. But the reason why I think this PR is a good way to move forward is because it allows for future change of adding Slider Tick hitobjects into strain evaluation without adding bandaids or messing up everything else. This would be as simple as creating OsuSliderSubDifficultyHitObject and evaluating it's difficulty, when those subobjects would be properly handled in Aim strain automatically and skipped in something like Speed. |
|
To see all the affected maps by the spinner bug you could calculate a sheet on this PR. |
2 participants
Proper fix of this - #32716
Creating this for visibility @stanriders @tsunyoku for how this stuff should be handled properly. With intention to expand it to sliders sub objects, as they have the same problem.
The line delta is inflated by the fact of moving ODHO into a different file.