Implement Sunnyxxy's Mania Rework #36342
Open
+2,498
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanriders
moved this from Pending Review
to In Progress
in Difficulty calculation changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a PR to RFC on code quality.
This does NOT match the huis page, it has a couple of changes and omitted features for the sake of simplicity. As a result, jacks are really strong compared to the rest of the skills. Porting everything 1:1 is possible in case the value differences are unacceptable.
All difficulties are preprocessed because Sunny's rework was originally written as a pass over all of the notes in the map, and the existence of smoothing makes this impossible to convert to a per-note system. The preprocessor is called from the CreateDifficultyHitobjects() method, I can move it if there is a more appropriate spot.
I've cleaned up the base branch a lot, but some individual code sections are still kind of messy, so please forgive them. I'd rather have reviews about overall code structure.