Skip to content

Conversation

willieyz
Copy link
Contributor

@willieyz willieyz force-pushed the test-consolidate-lint branch from 545af13 to 9a1759f Compare August 11, 2025 11:19
@willieyz willieyz marked this pull request as ready for review August 11, 2025 11:25
@willieyz willieyz requested a review from a team as a code owner August 11, 2025 11:25
Copy link
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willieyz! Something is not yet working correctly, because in fact not all source files have the Apache-2.0 OR MIT OR ISC license -- see e.g. https://github.com/pq-code-package/mldsa-native/blob/main/mldsa/native/aarch64/src/ntt.S. Somehow the script does not seem to catch this.

scripts/lint Outdated
fi
done
# For source files in dev/* and mldsa/*, we enforce `Apache-2.0 OR ISC OR MIT`
for file in $(git ls-files -- "*.[chsSi]" | grep "^dev/\|^mlkem/"); do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be mldsa, not mlkem.

Copy link
Contributor Author

@willieyz willieyz Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @hanno-becker,
Thank you for your reviewing, and apologies for my careless mistake...
After correcting it to use mldsa instead of mlkem, the script correctly catch the SPDX + Copyright headers error,
see following link:
https://github.com/pq-code-package/mldsa-native/actions/runs/17578845391/job/49930280691?pr=424
I have a question, for these two file(intt.S, ntt.S),
Should I update them to use Apache-2.0 OR ISC OR MIT as the script requires, instead of only MIT(same as mlkem-native), or should I modify the script so that it passes if only one of the licenses is present?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot just change licenses of code without asking the copyright owners - so that is not an option.

Let's temporarily whitelist these two files and add a TODO in the script it needs to be removed once licenses have been sorted out as a part of #381.

@willieyz willieyz force-pushed the test-consolidate-lint branch 3 times, most recently from 6cd2ee0 to ce1ec0c Compare September 10, 2025 07:23
Signed-off-by: willieyz <willie.zhao@chelpis.com>
@willieyz willieyz force-pushed the test-consolidate-lint branch from 694fb17 to b37d47f Compare September 15, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add shell liting and copyright checking in lint
3 participants