Skip to content

Split files into level-specific and level-generic #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Split files into level-specific and level-generic #437

wants to merge 2 commits into from

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Sep 4, 2025 •
edited
Loading

Following mlkem-native, I used poly_k.c as the name of the level-dependent files. While ML-DSA uses two parameters K and L, I think the consistency with mlkem is a good balance.

I can build addition elements into this PR, or we can split into a series.

@jakemas
Split files into level-specific and level-generic
edfd111 
Signed-off-by: Jake Massimo <jakemas@amazon.com>
@jakemas jakemas requested a review from a team as a code owner September 4, 2025 00:18
@jakemas
Fix CBMC proofs
8790846 
Signed-off-by: Jake Massimo <jakemas@amazon.com>
@jakemas jakemas changed the title Split files into level-specific and level-generic ML-DSA: Multi-level build Sep 4, 2025
@jakemas jakemas changed the title ML-DSA: Multi-level build Implement multi-level build Sep 4, 2025
hanno-becker

This comment was marked as outdated.

Sign in to view

hanno-becker
hanno-becker requested changes Sep 7, 2025
View reviewed changes
Copy link
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the logic behind the splitting? I was expecting functions in poly_k.c to be about polyveck or polyvecl, not poly, but that's not the case.

@hanno-becker hanno-becker changed the title Implement multi-level build Split files into level-specific and level-generic Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanno-becker hanno-becker hanno-becker requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split files into level-specific and level-generic
2 participants
@jakemas @hanno-becker