Mutable API: Specify initialSize independent of capacity#8
Open
bryphe wants to merge 2 commits intopqwy:masterfrom
Open
Mutable API: Specify initialSize independent of capacity#8bryphe wants to merge 2 commits intopqwy:masterfrom
bryphe wants to merge 2 commits intopqwy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for the great library!
For my scenario, it'd be preferable to not pre-allocate the
capacitywhen initializing the Lru Hashtable. I'd like to be able to bound the growth, and make guarantees that we do not exceed a certain size, but not necessarily allocate the full set of memory up-front.This isn't doable with the current API, because the
capacitypassed to thecreatemethod of the Mutable LRU is used to set the initial size of theHashtbl.t.To support this, I added an optional
initialSizeparameter tocreate- if not specified, it will default to capacity as before. If it is specified, it is used to set the initial size of the underlying hash table.