Open
Conversation
Note that MSVC doesn't support the __attribute__((unused)) construct. Signed-off-by: Ali Caglayan <alizter@gmail.com> Signed-off-by: Antonin Décimo <antonin@tarides.com>
MSVC doesn't support the __attribute__ compiler extension. It also has a different command-line syntax. Activate its warnings.
The OCaml runtime (as of 5.3) has no support for signals under Windows. Windows terminals don't support termios (tcgetattr/tcsetattr) functions. Avoid raising with unsupported functions.
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Apr 9, 2025
…semgrep-proprietary#3582) This can be removed once pqwy/notty#56 is released, or a new fork picking up the changes is published. This is broken out of semgrep/semgrep-proprietary#3550 synced from Pro 0fe7b0b3447a9d403d3adf785122fdde1e8a117e
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Apr 9, 2025
…semgrep-proprietary#3582) This can be removed once pqwy/notty#56 is released, or a new fork picking up the changes is published. This is broken out of semgrep/semgrep-proprietary#3550 synced from Pro 0fe7b0b3447a9d403d3adf785122fdde1e8a117e
emjin
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Apr 9, 2025
…semgrep-proprietary#3582) This can be removed once pqwy/notty#56 is released, or a new fork picking up the changes is published. This is broken out of semgrep/semgrep-proprietary#3550 synced from Pro 0fe7b0b3447a9d403d3adf785122fdde1e8a117e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for Windows to notty. We can retrieve the initial size of the terminal, but it's difficult (or nearly impossible) to be notified of changes to the dimensions of the window. The OCaml runtime (as of 5.3) doesn't support signals on Windows, and Windows has no support for the termios features, so disable them both. Passing by, also allow notty to be build with MSVC/clang-cl.
The PR is based on #54.