Tidy up async behaviour #93
Conversation
We're not doing anything CPU intensive not lots of filesystem I/O. We don't need multiple threads.
This task spawns a new thread which takes a blocking lock on a mutex. Just take a non-blocking lock on the current thread.
|
ok i see you addressed my comment before i managed to type it out :D (meant to reply this on #91) |
|
i don't remember why i decided to make all the |
| } | ||
|
|
||
| #[tokio::main] | ||
| #[tokio::main(flavor = "current_thread")] |
There was a problem hiding this comment.
i want to try this out before merging if it doesn't cause any issues (if it does that would be a bug, but still i don't want to merge it before testing). please let me know when you consider the PR ready
There was a problem hiding this comment.
oki^^ i'll try to test it soon and if i don't see any weird behaviour we can merge
|
i've played around with the patched version and haven't run into any issues. thanks for the contribution^^ |
* Disable multi-thread RT We're not doing anything CPU intensive not lots of filesystem I/O. We don't need multiple threads. * Remove pointless blocking task This task spawns a new thread which takes a blocking lock on a mutex. Just take a non-blocking lock on the current thread. * Avoid blocking locks * Remove unnecessary async/await * Disable unused tokio features
2 participants
asyncfrom functions that don't need it.