This repository was archived by the owner on Dec 27, 2018. It is now read-only.
Allow specifying global mocha timeout#9
Open
Ben305 wants to merge 1 commit intopracticalmeteor:practicalmeteorfrom
Open
Allow specifying global mocha timeout#9Ben305 wants to merge 1 commit intopracticalmeteor:practicalmeteorfrom
Ben305 wants to merge 1 commit intopracticalmeteor:practicalmeteorfrom
Conversation
This was referenced May 26, 2017
Closed
|
@aldeed Wondering about the possibility of getting this PR in, as right now building the package locally with this PR is really slowing down the tests. Thanks! |
Collaborator
|
@arist0tl3 Although I could merge this, I'm not listed as a maintainer so I couldn't publish it. I haven't heard much from @jsep or @rbabayoff lately so I'm not sure if this is abandoned. Might need to consider forking it into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our build server is sometimes a bit slower, and executing a single test can take longer than 2000ms. Sometimes, even a
beforeEachis marked as failed because it takes longer than 2000ms.This PR allows to set the global mocha timeout by setting an environment variable, which will override the default value.