Switch to the new uplc_turbo to avoid memory leaks#669
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR removes the workspace Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@crates/amaru-plutus/src/arena_pool.rs`:
- Around line 21-23: The workspace still declares bumpalo and the file imports
bumpalo::Bump even though BumpPool (the type alias) only uses
uplc_turbo::arena::Arena; remove the unused Bump import from
crates/amaru-plutus/src/arena_pool.rs (keep uplc_turbo::arena::Arena and the
BumpPool alias) and drop the bumpalo entry from the root Cargo.toml workspace
dependencies if no member crate directly depends on bumpalo (verify no other
crates need it first, otherwise leave it).
f1a9cfe to
26aadfe
Compare
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
26aadfe to
a441497
Compare
|
With Fresh eyes on it I see there's another lockfile in the repo. |
a441497 to
ad4b985
Compare
Signed-off-by: Jacob Finkelman <YeomanYaacov@gmail.com>
ad4b985 to
63a2265
Compare
|
CI failures seem also to be occurring on other recent PR's (https://github.com/pragma-org/amaru/actions/runs/21783366269/job/62850815322) and appear to be unrelated to my code changes. |
Bring in the fixes from pragma-org/uplc#36
Summary by CodeRabbit
Chores
Refactor