fix(ui): use popover opacity for floating overlays#122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toasts, OSD and media popout used to inherit opacity from widgets to create a uniform look, this is great until your run with:
And your toasts and OSD become practically invisible except for the font... With popovers this has been fixed by making them get the highest opacity between bar and widget as well as a separate setting to control popover opacity.
This PR makes the other surfaces(Toasts, OSD, media popout) use the same opacity as popovers.
I know this is not the best long term solution and a more intuitive control is probably need but that will have to wait for larger config overhaul.