Fixed errors with submitted select field values #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate options and incorrectly set the default selected value.
…ctly due to missing name attribute.
LukaszPrzybysz
pushed a commit
to LukaszPrzybysz/ddslick
that referenced
this pull request
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library to submit multiple select fields in the same form, the select field values were not captured in the form's POST data due to the name attribute not being set. Even after fixing this issue, select fields after the first would include duplicate copies of the first field's options, as well as setting the default selected option to that of the first select field for all fields. I'm sure other users who use this plugin for complex forms will appreciate these bugs being fixed.